Feat ContextProxy to improve state management #1235
Conversation
|
dosubot
bot
added
size:XXL
samhvw8
force-pushed
the
feat/context-proxy
branch
2 times, most recently
from
c12aea5 to
fc11d96
Compare
- Add ContextProxy class as a wrapper around VSCode's ExtensionContext - Implement batched state updates for performance optimization - Update ClineProvider to use ContextProxy instead of direct context access - Add comprehensive test coverage for ContextProxy - Extract SECRET_KEYS and GLOBAL_STATE_KEYS constants for better maintainability
samhvw8
force-pushed
the
feat/context-proxy
branch
from
fc11d96 to
fbb5a19
Compare
| @@ -81,6 +97,79 @@ export type GlobalStateKey = | |||
| | "unboundModelInfo" | |||
| | "modelTemperature" | |||
| | "modelMaxTokens" | |||
| | "anthropicThinking" // TODO: Rename to `modelMaxThinkingTokens`. | |||
| | "modelMaxThinkingTokens" | |||
There was a problem hiding this comment.
Do we still have references to anthropicThinking? Maybe should leave this cleanup for another PR
| // Build the apiConfiguration object combining state values and secrets | ||
| const apiConfiguration: ApiConfiguration = { | ||
| apiProvider, | ||
| apiModelId: stateValues.apiModelId, |
There was a problem hiding this comment.
Is there some way to use the globalstatekeys here so we don't need to repeat this big list? Or is it a different subset of the list?
| } | ||
| } | ||
|
|
||
| // Called when the provider is disposing |
Description
This feature will we can open multiple window (which can have different config (mode / api config))
Type of change
How Has This Been Tested?
Checklist:
Additional context
Related Issues
Reviewers
Important
Introduces
ContextProxyfor efficient state management inClineProvider, with batched updates and comprehensive testing.ContextProxyclass incontextProxy.tsto buffer state changes and secrets, committing them on request or disposal.ClineProvider.tswithContextProxyfor efficient state management.SECRET_KEYSandGLOBAL_STATE_KEYSconstants inglobalState.tsfor maintainability.ContextProxyincontextProxy.test.ts.ClineProvider.test.tsto mock and testContextProxyintegration.ClineProviderto useContextProxyfor state and secret management, ensuring proper disposal and state handling.This description was created by
for dec624c. It will automatically update as commits are pushed.